View ProjeQtOr On SourceForge.net
ProjeQtOr - Project Management Tool
Support us on Capterra
OIN - Open Invention Network
ProjeQtOr free project management software - Security checkValidDateTime - ProjeQtOr
 
 

Security checkValidDateTime

More
10 Jan 2017 08:30 #1 by antonio.grr
Hi,
in checkValidDateTime of Security the code

if ($len < 10) {
$time = $dateTime;
}
if ($len == 10) {
$date = $dateTime;
} else { // $len > 10

should be modified as

if ($len < 10) {
$time = $dateTime;
} else if ($len == 10) {
$date = $dateTime;
} else { // $len > 10

or the last else will be verified also when len < 10

If you try to validate a datetime having len < 5 you will try tp split a null datetime ...

I think you could better change each
$datetime = null;
with a
return null;
so avoiding processing wrong cases.
Best regards.

Please Log in or Create an account to join the conversation.

More
10 Jan 2017 20:56 #2 by babynus
Replied by babynus on topic Security checkValidDateTime
You'r right, there is an else missing.
It will be included in next patch.
This should not be big issue except possibly for import, as dates are formatted in date fields.

Improvement on datetime=null; will also be included.

Thanks for reporting.

Babynus
Administrator of ProjeQtOr web site

Please Log in or Create an account to join the conversation.

Moderators: babynusprotion
Time to create page: 0.031 seconds

Cookies settings

×

Functional Cookies

Ce site utilise des cookies pour assurer son bon fonctionnement et ne peuvent pas être désactivés de nos systèmes. Nous ne les utilisons pas à des fins publicitaires. Si ces cookies sont bloqués, certaines parties du site ne pourront pas fonctionner.

Session

Please login to see yours activities!

Other cookies

Ce site web utilise un certain nombre de cookies pour gérer, par exemple, les sessions utilisateurs.