View ProjeQtOr On SourceForge.net
ProjeQtOr - Project Management Tool
Support us on Capterra
OIN - Open Invention Network
ProjeQtOr free project management software - Misplaced organizeButtonsEnd() call - ProjeQtOr
 
 

Misplaced organizeButtonsEnd() call

More
16 May 2017 08:59 #1 by antonio.grr
Hi.
At first sight it seems that the call to the function organizeButtonsEnd() in objectButtns is inside the if ($mailable and $mailable->id) ;
but I believe it must be called in any case, as the organizeButtons() sequence is alredy started. Please check.
In my version I created function fro each button ( e.g. function drawMultiUpdateButton($objectClass, $objectClassi18n, $noselect) ) so the code appears more readable, like
....
//$displayButton=( $buttonCheckListVisible=="visible")?'void':'none';
if ($buttonCheckListVisible == "visible" and $obj->id) {
$this->organizeButtons($obj);
}
$this->drawCheckListButton($objectClass, $buttonCheckListVisible);
$paramHistoryVisible = Parameter::getUserParameter('displayHistory');
if ($paramHistoryVisible == 'REQ' and $obj->id) {
$this->organizeButtons($obj);
}
$this->drawHistoryButton($objectClass, $objectId, $paramHistoryVisible);
}
$this->organizeButtonsEnd();
....
Best regards

Please Log in or Create an account to join the conversation.

More
17 May 2017 09:00 #2 by babynus
You're right,

In fact, it is the closure for test "if ($mailable and $mailable->id" that is much to far.
In encloses several buttons that should be displayed even if not mailable (history, checklist, ...)

Thanks for reporting.

Babynus
Administrator of ProjeQtOr web site

Please Log in or Create an account to join the conversation.

Moderators: babynusprotion
Time to create page: 0.027 seconds

Cookies settings

×

Functional Cookies

Ce site utilise des cookies pour assurer son bon fonctionnement et ne peuvent pas être désactivés de nos systèmes. Nous ne les utilisons pas à des fins publicitaires. Si ces cookies sont bloqués, certaines parties du site ne pourront pas fonctionner.

Session

Please login to see yours activities!

Other cookies

Ce site web utilise un certain nombre de cookies pour gérer, par exemple, les sessions utilisateurs.