ProjeQtOr free project management software - MODULE OF MANAGEMENT OF REGULATED ABSENCES - Page 2 - ProjeQtOr
 

MODULE OF MANAGEMENT OF REGULATED ABSENCES

More
03 Jan 2019 15:12 #7 by babynus
Hi,

Thanks for taking into account my remarks.
I'll have a llok to new patch.

* isLeaveMngWorkflow on workflow
Why not just select a workflow (on global parameters or else)
The workflow can not be changed.
Indeed, it can only have 3 statuses:
* Recorded = Absence requested
* Validated = Absence accepted
* Canceled = Absence denied

This is bad design as it expects the status have not been deleted or hidden by admin.
As list of statuses may be completely modified, we cannot rely on fix list.
You must rely on "isDone" and "isCancelled" on each status to give move freedom of configuration.
Possibily someone could need a 2 phases validation or another workflow (for instance ass a status "submit for validation" after "recorded"), requiring more steps that only the 3 you defined.

* Issue with PHPExcel.php
If I leave line 38 in projeqtor.php
require_once '../external/PHPExcel/Classes/PHPExcel.php';
I get an error.
It seems the Autoload in PHPExcel.php sets a mess with projeqtor
Is the directory 'PHPExcel' created in 'external'.
For me, everything is ok.
Maybe the 'external' patch did not integrate everything.
When in doubt, the PHPExcel zip is attached.

With patch, same issue.
After unzipping the zip file to get full content of library, issue disepears.

I am still facing small issues with patch as some line breaks are missing (I don't know why).
In most cases, it is not an issue, but it may by on when the missing line break is at end of comment followed by some code.
For instance in login.php, line 44, I had :
// MTY - MULTI CALENDAR         if (getSessionValue('setup', null, true) or version_compare(ltrim(Sql::getDbVersion(),'V'), '5.0.0',"<") ) {
that I had to change to
// MTY - MULTI CALENDAR      
   if (getSessionValue('setup', null, true) or version_compare(ltrim(Sql::getDbVersion(),'V'), '5.0.0',"<") ) {
to have code work.
I don't know if you have a clue to avoid this issue in the patch...

Babynus
Administrator of ProjeQtOr web site

Please Connexion or Create an account to join the conversation.

More
17 Jan 2019 23:29 #8 by tabary
Hello

First of all: my best wishes for this new year.

Here is a V2 of the module 'Absences Regulaires'.

From now on, it is possible to associate any workflow with any type of regulated absence.
This makes the use of the module more flexible and avoids bad design.

It is now possible to have as many validation processes for a regulated absence as you want.

However, regulated absences only have 4 transitions (new concept: see the new documentation):
  • Submitted: Absence is submitted and waiting for validation.
  • Accepted: The submitted absence was accepted
  • Rejected: The submitted absence was rejected
  • Neutral: none of the previous 3 The absence has been created but the submission for validation is not yet done.
In the first 3 cases, only the absence status can be modified by either the manager of the employee for whom the absence is made or the administrator of the 'Regulated Absence' module.

For lines without CR, I added a plugin to netBeans that should normally fix the problem.

Hope this will suit you.

Best regards

Please Connexion or Create an account to join the conversation.

More
20 Jan 2019 14:18 - 20 Jan 2019 14:20 #9 by babynus
Many Thanks.

I'll have a look to include it in V7.5 (that will possibly become V8.0)

Babynus
Administrator of ProjeQtOr web site
Last edit: 20 Jan 2019 14:20 by babynus.

Please Connexion or Create an account to join the conversation.

Moderators: babynusprotion
Time to create page: 0.031 seconds