Hi,
Thanks for taking into account my remarks.
I'll have a llok to new patch.
* isLeaveMngWorkflow on workflow
Why not just select a workflow (on global parameters or else)
The workflow can not be changed.
Indeed, it can only have 3 statuses:
* Recorded = Absence requested
* Validated = Absence accepted
* Canceled = Absence denied
This is bad design as it expects the status have not been deleted or hidden by admin.
As list of statuses may be completely modified, we cannot rely on fix list.
You must rely on "isDone" and "isCancelled" on each status to give move freedom of configuration.
Possibily someone could need a 2 phases validation or another workflow (for instance ass a status "submit for validation" after "recorded"), requiring more steps that only the 3 you defined.
* Issue with PHPExcel.php
If I leave line 38 in projeqtor.php
require_once '../external/PHPExcel/Classes/PHPExcel.php';
I get an error.
It seems the Autoload in PHPExcel.php sets a mess with projeqtor
Is the directory 'PHPExcel' created in 'external'.
For me, everything is ok.
Maybe the 'external' patch did not integrate everything.
When in doubt, the PHPExcel zip is attached.
With patch, same issue.
After unzipping the zip file to get full content of library, issue disepears.
I am still facing small issues with patch as some line breaks are missing (I don't know why).
In most cases, it is not an issue, but it may by on when the missing line break is at end of comment followed by some code.
For instance in login.php, line 44, I had :
// MTY - MULTI CALENDAR if (getSessionValue('setup', null, true) or version_compare(ltrim(Sql::getDbVersion(),'V'), '5.0.0',"<") ) {
that I had to change to
// MTY - MULTI CALENDAR
if (getSessionValue('setup', null, true) or version_compare(ltrim(Sql::getDbVersion(),'V'), '5.0.0',"<") ) {
to have code work.
I don't know if you have a clue to avoid this issue in the patch...