MODULE OF MANAGEMENT OF REGULATED ABSENCES

Hi Marc,

Thank you for this new contribution.
I've quickly read the documentation : it seems great.

To ba able to integrate the code, It will be defficult to treat folders as you send, as it may rease some of our code.
If you did this from branch V7.4, could you please generate a patch file, that will integrate only changes.
It will help me a lot to integrate your changes.
Thanks in advance, and thanks again for this contribution.

NB : about integration as a plugin, it will not be possible as it seems you added items in core code (SqlElement.php, projeqtor.pjp)
But maybe activation through a dedicated parameter, as you did for Notification System, may be a good alternative.

Hi,

GREAT !

Thnak you very mush.
I will integrate this as soon as possible and give you a feedback.

Thnaks for your contribution.

Hi,

I tested your contribution.

First, it is impressive
There are many really very good ideas.

Here are my first (I hope constructive) remarks :

* Attention, in db scripts, name of tables MUST be in lowercase
This is a technical constraint : if names are stored with uppercases, issue may occur with linux and postgresql

* isLeaveManager on resource
maybe this, being an access right, may be defined elsewhere

* isLeaveMngProject on project
Why not use "Administrative" project ?

* isLeaveMngWorkflow on workflow
Why not just select a workflow (on global parameters or else)

* Issue with PHPExcel.php
If I leave line 38 in projeqtor.php
require_once '../external/PHPExcel/Classes/PHPExcel.php';
I get an error.
It seems the Autoload in PHPExcel.php sets a mess with projeqtor

* Icons are missing in patchs
Ok, I found them in full version

* Translation missing
I found translations in lang.js but not sure I found all
Could you please send changes or lang.xls file ?
(not found in full version)

* Some code is missing in the patchs
For instance "addGenericBankOffDays" is not is the patch
I found it in full version, in projectorDialog.js.
I could copy it, but I think other parts of code are not working.
Identifying all missing parts is almost impossible on my side.
Moreover, this code should be included in projeqtorHR.js.
Also, some features were not working, and I found that some complete scripts were missing (leaveCalendar.php, leaveCalendarPopupErrorAndResult.php, leavesSystemHabilitation.php, dashboardEmployeeManager.php)
I'm noit sure I found all missing items.

* Some minor ergonomic issues are remaining
For instance, in leave calendar screen,
- there is an extra unnecessary vertical scrollbar
- buttons have strange caracters as caption (surely some non utf8 encoding of script)
- you can move a leave period, this show a pop-up, chenge change does not seem to be saved.

As a summary, there is great potential, but it needs more reliability and integration will require hard work.
So we won't be able to integrate it on V7.4.
Moreover, this module will push projeqtor to V8
So we'll plan to integrate it on V8.0 that will replace V7.5 (or possibly replace V7.5+V7.6).
We'll possibly also try and include modules management in ProjeQtOr on this version.
The idea is to be able to select, at installation and able to change later, the "modules" that will be used :
- HR
- Financial
- Configuration (products, component, versions)
- ...
to be able to "remove" parts that will not be used depending on needs of the company.

Thanks again for this contribution.
It would be great if you could provide patch with fixing of upper remarks.