View ProjeQtOr On SourceForge.net
ProjeQtOr - Project Management Tool
Support us on Capterra
OIN - Open Invention Network
ProjeQtOr free project management software - MAJOR - Security Bug with LDAP authentication - ProjeQtOr
 
 

MAJOR - Security Bug with LDAP authentication

More
09 Jul 2014 21:49 #1 by neopk
MAJOR - Security Bug with LDAP authentication was created by neopk
Hi,

I discovered a bug when we use LDAP authentication.
I put LDAP username in login input, then i submit login with empty password, we obtain a successfull authentication.

TO fix the problem i modified the /tool/loginCheck.php file on line 21 : replace if ($password=="") {...} by if (AesCtr::decrypt($password, $_SESSION=="") . Password is encrypt, so $password is never empty, then when the function ldap_bind (/model/User.php line 798) is used, it always return true because of empty password.

Thank you.

Please Log in or Create an account to join the conversation.

More
09 Jul 2014 22:35 #2 by babynus
Replied by babynus on topic MAJOR - Security Bug with LDAP authentication
Hi,

Thank you for this acurate analysis.

What seems strange to me is that code on line 805 in User.php should refuse empty password.
if (! $bind_user or !$parampassword) {
//debugLog("incorrect binding");			
				return "login";
			}
Moreover, try and disable anonymous connection to your LDAP : empty password should fail.

Anyway, your proposale is cute and will secure this phase.
I will include it in next patch version (V4.3.3)
Thanks.
Babynus
Administrator of ProjeQtOr web site
The following user(s) said Thank You: neopk

Please Log in or Create an account to join the conversation.

More
09 Jul 2014 22:51 #3 by neopk
Replied by neopk on topic MAJOR - Security Bug with LDAP authentication
Indeed, this verification seems not to be in 4.1.2 version (we are again on this version), so this bug is probably not on lastests versions. I apologize !

Maybe it will not be fixed yet next time. :)

Thanks for your reply.

Please Log in or Create an account to join the conversation.

More
10 Jul 2014 14:21 #4 by mdocken
Replied by mdocken on topic MAJOR - Security Bug with LDAP authentication
I am on 4.3.2 with ldap auth. It refuses blank password.

Please Log in or Create an account to join the conversation.

Moderators: babynus, protion
Time to create page: 0.048 seconds

Cookies settings

×

Functional Cookies

Ce site utilise des cookies pour assurer son bon fonctionnement et ne peuvent pas être désactivés de nos systèmes. Nous ne les utilisons pas à des fins publicitaires. Si ces cookies sont bloqués, certaines parties du site ne pourront pas fonctionner.

Session

Please login to see yours activities!

Other cookies

Ce site web utilise un certain nombre de cookies pour gérer, par exemple, les sessions utilisateurs.

Login Form